On Wed, Dec 13, 2023 at 5:15 PM Kent Gibson <warthog618@xxxxxxxxx> wrote: > > On Wed, Dec 13, 2023 at 04:40:12PM +0100, Bartosz Golaszewski wrote: > > On Wed, Dec 13, 2023 at 3:27 PM Kent Gibson <warthog618@xxxxxxxxx> wrote: > > > > > > > > > > > > > > +out_unlock: > > > > > + spin_unlock(&supinfo.lock); > > > > > > > > No use of cleanup.h? > > > > > > > > > > Again, that is new to me, so no not yet. > > > > > > > Yep, please use a guard, they're awesome. :) > > > > Before I go nuts and switch everything over, is it ok to put a return > within the scoped_guard - it will automatically unlock on the way out? > Yes! This is precisely why they're so great. Bart > Cheers, > Kent.