Re: [PATCH 2/2] pinctrl: stm32: fix GPIO level interrupts

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Dec 7, 2023 at 10:56 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Mon, Dec 4, 2023 at 9:35 PM Ben Wolsieffer

> <ben.wolsieffer@xxxxxxxxxxx> wrote:
>
> > The STM32 doesn't support GPIO level interrupts in hardware, so the
> > driver tries to emulate them using edge interrupts, by retriggering the
> > interrupt if necessary based on the pin state after the handler
> > finishes.
> >
> > Currently, this functionality does not work because the irqchip uses
> > handle_edge_irq(), which doesn't run the irq_eoi() or irq_unmask()
> > callbacks after handling the interrupt. This patch fixes this by using
> > handle_level_irq() for level interrupts, which causes irq_unmask() to be
> > called to retrigger the interrupt.
> >
> > Signed-off-by: Ben Wolsieffer <ben.wolsieffer@xxxxxxxxxxx>
>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> Marc Z can apply all the patches to the irq tree once he's happy
> with the solution.

I see Marc stopped doing irq_chips, so tglx then!

Yours,
Linus Walleij