Re: [PATCH] pinctrl: qcom: fail to retrieve configuration from invalid pin groups

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Nov 28, 2023 at 3:03 AM Richard Acayan <mailingradian@xxxxxxxxx> wrote:

> The pinconf-groups debugfs file dumps each valid configuration item of
> all pin groups. Some platforms and devices may have pin groups which
> cannot be accessed, according to commit 691bf5d5a7bf ("pinctrl: qcom:
> Don't allow protected pins to be requested"). Fail for each
> configuration item of an invalid pin group by checking the GPIO chip's
> valid mask.
>
> The validity of the pin group cannot be checked in the generic pinconf
> dump (function "pinconf_generic_dump_one"), as it does not directly
> interact with the gpiochip or the pinmux callbacks (which would give it
> access to the request callback). Instead, an entry contains the ID and
> name of the pingroup with no properties when all items fail.
>
> Signed-off-by: Richard Acayan <mailingradian@xxxxxxxxx>

Looks reasonable so patch applied.

Yours,
Linus Walleij