On Thu, Nov 30, 2023 at 03:37:48PM +0200, Andy Shevchenko wrote: > On Thu, Nov 30, 2023 at 11:40:23AM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> ... > > +#else > > +#define gpio_sim_dbg_show NULL > > +#endif /* CONFIG_DEBUG_FS */ > > I;m wondering if you can use PTR_IF() instead of this ugly ifdeffery. If brave enough, you can even propose a new macro like #define debugfs_ptr(ptr) ... (see pm_sleep_ptr() / pm_ptr() as examples). -- With Best Regards, Andy Shevchenko
Re: [PATCH] gpio: sim: implement the dbg_show() callback
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] gpio: sim: implement the dbg_show() callback
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Thu, 30 Nov 2023 15:39:04 +0200
- In-reply-to: <ZWiQLEz6P3vbZgx0@smile.fi.intel.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20231130104023.11885-1-brgl@bgdev.pl> <ZWiQLEz6P3vbZgx0@smile.fi.intel.com>
- References:
- [PATCH] gpio: sim: implement the dbg_show() callback
- From: Bartosz Golaszewski
- Re: [PATCH] gpio: sim: implement the dbg_show() callback
- From: Andy Shevchenko
- [PATCH] gpio: sim: implement the dbg_show() callback
- Prev by Date: Re: [PATCH] gpio: sim: implement the dbg_show() callback
- Next by Date: [PATCH v2 00/10] gpio/pinctrl: replace gpiochip_is_requested() with a safer interface
- Previous by thread: Re: [PATCH] gpio: sim: implement the dbg_show() callback
- Next by thread: Re: [PATCH] gpio: sim: implement the dbg_show() callback
- Index(es):
 |