On 30.11.2023 03:40, Tengfei Fan wrote: > Use .remove_new() instead of .remove() for converting to platform remove > callback returning void. > > Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx> > --- You misunderstood me, this series now introduces a driver with known issues and patches them up right away in subsequent changes. What you should do in such situations is squash the fixups into the newly added driver (e.g. by running git rebase -i baseofyourtree and changing 'pick' to 'f' (for 'fixup') on the last two patches). Konrad
Re: [PATCH v5 3/4] pinctrl: qcom: sm4450: Convert to platform remove callback returning void
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v5 3/4] pinctrl: qcom: sm4450: Convert to platform remove callback returning void
- From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
- Date: Thu, 30 Nov 2023 11:36:48 +0100
- In-reply-to: <20231130024046.25938-4-quic_tengfan@quicinc.com>
- References: <20231130024046.25938-1-quic_tengfan@quicinc.com> <20231130024046.25938-4-quic_tengfan@quicinc.com>
- User-agent: Mozilla Thunderbird
- Follow-Ups:
- References:
- Prev by Date: Re: [PATCH v4 06/23] pinctrl: core: Make pins const unsigned int pointer in struct group_desc
- Next by Date: [PATCH] gpio: sim: implement the dbg_show() callback
- Previous by thread: [PATCH v5 3/4] pinctrl: qcom: sm4450: Convert to platform remove callback returning void
- Next by thread: Re: [PATCH v5 3/4] pinctrl: qcom: sm4450: Convert to platform remove callback returning void
- Index(es):
 |