On Wed, 29 Nov 2023 at 04:09, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> The most interesting patch is the list iterator fix in the core by Maria
> Yu, it took a while for me to realize what was going on there.
That commit message still doesn't explain what the problem was.
Why is p->state volatile there? It seems to be a serious locking bug
if p->state can randomly change there, and the READ_ONCE() looks like
a "this hides the problem" rather than an actual real fix.
Linus
Re: [GIT PULL] Pin control fixes for v6.7
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [GIT PULL] Pin control fixes for v6.7
- From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 29 Nov 2023 06:55:57 -0800
- In-reply-to: <CACRpkdZtVNZFWSUgb4=gUE2mQRb=aT_3=zRv1U71Vsq0Mm34eg@mail.gmail.com>
- References: <CACRpkdZtVNZFWSUgb4=gUE2mQRb=aT_3=zRv1U71Vsq0Mm34eg@mail.gmail.com>
- Follow-Ups:
- Re: [GIT PULL] Pin control fixes for v6.7
- From: Linus Walleij
- Re: [GIT PULL] Pin control fixes for v6.7
- References:
- [GIT PULL] Pin control fixes for v6.7
- From: Linus Walleij
- [GIT PULL] Pin control fixes for v6.7
- Prev by Date: Re: [PATCH 09/10] gpiolib: use gpiochip_dup_line_label() in for_each helpers
- Next by Date: Re: [PATCH 01/10] gpiolib: provide gpiochip_dup_line_label()
- Previous by thread: [GIT PULL] Pin control fixes for v6.7
- Next by thread: Re: [GIT PULL] Pin control fixes for v6.7
- Index(es):
 |