RE: [PATCH] pinctrl: mlxbf3: fix wrong return pointer check in mlxbf3_pinctrl_probe()

[Asmaa Mnebhi <asmaa@xxxxxxxxxx>]

Acked-by: Asmaa Mnebhi <asmaa@xxxxxxxxxx>

> -----Original Message-----
> From: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> Sent: Tuesday, November 28, 2023 9:44 PM
> To: linux-gpio@xxxxxxxxxxxxxxx
> Cc: linus.walleij@xxxxxxxxxx; andy.shevchenko@xxxxxxxxx; Asmaa Mnebhi
> <asmaa@xxxxxxxxxx>; yangyingliang@xxxxxxxxxx
> Subject: [PATCH] pinctrl: mlxbf3: fix wrong return pointer check in
> mlxbf3_pinctrl_probe()
> Importance: High
> 
> Fix wrong return pointer check after calling
> devm_platform_ioremap_resource().
> 
> Fixes: d11f932808dc ("pinctrl: mlxbf3: Add pinctrl driver support")
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
>  drivers/pinctrl/pinctrl-mlxbf3.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-mlxbf3.c b/drivers/pinctrl/pinctrl-mlxbf3.c
> index 7d1713824a89..ffb5dda364dc 100644
> --- a/drivers/pinctrl/pinctrl-mlxbf3.c
> +++ b/drivers/pinctrl/pinctrl-mlxbf3.c
> @@ -259,16 +259,16 @@ static int mlxbf3_pinctrl_probe(struct
> platform_device *pdev)
>  		return PTR_ERR(priv->fw_ctrl_set0);
> 
>  	priv->fw_ctrl_clr0 = devm_platform_ioremap_resource(pdev, 1);
> -	if (IS_ERR(priv->fw_ctrl_set0))
> -		return PTR_ERR(priv->fw_ctrl_set0);
> +	if (IS_ERR(priv->fw_ctrl_clr0))
> +		return PTR_ERR(priv->fw_ctrl_clr0);
> 
>  	priv->fw_ctrl_set1 = devm_platform_ioremap_resource(pdev, 2);
> -	if (IS_ERR(priv->fw_ctrl_set0))
> -		return PTR_ERR(priv->fw_ctrl_set0);
> +	if (IS_ERR(priv->fw_ctrl_set1))
> +		return PTR_ERR(priv->fw_ctrl_set1);
> 
>  	priv->fw_ctrl_clr1 = devm_platform_ioremap_resource(pdev, 3);
> -	if (IS_ERR(priv->fw_ctrl_set0))
> -		return PTR_ERR(priv->fw_ctrl_set0);
> +	if (IS_ERR(priv->fw_ctrl_clr1))
> +		return PTR_ERR(priv->fw_ctrl_clr1);
> 
>  	ret = devm_pinctrl_register_and_init(dev,
>  					     &mlxbf3_pin_desc,
> --
> 2.25.1