Hi Linus, On Fri, 24 Nov 2023 at 13:30, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Fri, Nov 24, 2023 at 11:09:07AM +0100, Linus Walleij wrote: > > On Tue, Nov 21, 2023 at 7:11 PM Andy Shevchenko > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > On Mon, Nov 20, 2023 at 09:48:02PM +0200, Andy Shevchenko wrote: > > > > > > The pin control header provides struct pingroup and PINCTRL_PINGROUP() macro. > > > > Utilize them instead of open coded variants in the driver. > > > > > > Linus, I dunno if you are going to apply this sooner (assuming Jonathan is okay > > > with the change), but I have a bigger pending series where this will be a > > > prerequisite. So, when I will be ready and if it's not being applied (yet), > > > I'll include it into the bigger series as well. > > > > No answer from Jonathan but I just applied another Nuvoton patch from > > Tomer, so maybe Tomer can look at/test this patch? Sorry, but I do not have wpcm450 board to test this patch. In general, the patch looks fine. > > Jonathan acked it in the reincarnation in the series (see my big one). > > -- > With Best Regards, > Andy Shevchenko > > Sorry I couldn't help. Best regards, Tomer