Re: [PATCH v2 1/2] dt-bindings: gpio: realtek: Add realtek,rtd-gpio

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 16/11/2023 12:14, Tzuyi Chang wrote:
> Add the device tree bindings for the Realtek DHC(Digital Home Center)
> RTD SoCs GPIO controllers.
> 
> Signed-off-by: Tzuyi Chang <tychang@xxxxxxxxxxx>
> ---
> v1 to v2 change:
>     1. Add description for DHC RTD SoCs.
>     2. Revise the compatible names.
>     3. Add descriptions for reg and interrupts properties.
> ---
>  .../bindings/gpio/realtek,rtd-gpio.yaml       | 74 +++++++++++++++++++
>  1 file changed, 74 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml
> 
> diff --git a/Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml b/Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml
> new file mode 100644
> index 000000000000..11c8278801c3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright 2023 Realtek Semiconductor Corporation
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/realtek,rtd-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Realtek DHC GPIO controller
> +
> +maintainers:
> +  - Tzuyi Chang <tychang@xxxxxxxxxxx>
> +
> +description:
> +  The GPIO controller is designed for the Realtek DHC (Digital Home Center)
> +  RTD SoC family, which are high-definition media processor SoCs.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:

Drop items.

> +          - enum:
> +              - realtek,rtd1295-misc-gpio
> +              - realtek,rtd1295-iso-gpio
> +              - realtek,rtd1395-iso-gpio
> +              - realtek,rtd1619-iso-gpio
> +      - items:
> +          - enum:
> +              - realtek,rtd1319-iso-gpio
> +              - realtek,rtd1619b-iso-gpio
> +              - realtek,rtd1319d-iso-gpio
> +              - realtek,rtd1315e-iso-gpio
> +          - const: realtek,rtd-gpio

Either you use generic compatible for everything or not. Other variants
do not use generic compatible, so neither should these. Use SoC-specific
compatible as fallback.

I asked you to to drop this compatible. I could not be more specific, so
you just ignored this remark.

So again: what is "rtd"? Why it does not appear anywhere in description
or title? No, drop it.


Best regards,
Krzysztof