Re: [PATCH 03/17] dt-bindings: i2c: samsung,s3c2410-i2c: add specific compatibles for existing SoC
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 03/17] dt-bindings: i2c: samsung,s3c2410-i2c: add specific compatibles for existing SoC
- From: Wolfram Sang <wsa@xxxxxxxxxx>
- Date: Thu, 9 Nov 2023 20:22:29 +0100
- In-reply-to: <20231108104343.24192-4-krzysztof.kozlowski@linaro.org>
- Mail-followup-to: Wolfram Sang <wsa@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>, David Airlie <airlied@xxxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>, Maxime Ripard <mripard@xxxxxxxxxx>, Thomas Zimmermann <tzimmermann@xxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, Alim Akhtar <alim.akhtar@xxxxxxxxxxx>, Andi Shyti <andi.shyti@xxxxxxxxxx>, Jonathan Cameron <jic23@xxxxxxxxxx>, Lars-Peter Clausen <lars@xxxxxxxxxx>, Lee Jones <lee@xxxxxxxxxx>, Ulf Hansson <ulf.hansson@xxxxxxxxxx>, Tomasz Figa <tomasz.figa@xxxxxxxxx>, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Thierry Reding <thierry.reding@xxxxxxxxx>, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>, Alessandro Zummo <a.zummo@xxxxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Jaehoon Chung <jh80.chung@xxxxxxxxxxx>, Sam Protsenko <semen.protsenko@xxxxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-iio@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-gpio@xxxxxxxxxxxxxxx, linux-pwm@xxxxxxxxxxxxxxx, linux-rtc@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx, linux-sound@xxxxxxxxxxxxxxx
- References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-4-krzysztof.kozlowski@linaro.org>
On Wed, Nov 08, 2023 at 11:43:29AM +0100, Krzysztof Kozlowski wrote:
> Samsung Exynos SoC reuses several devices from older designs, thus
> historically we kept the old (block's) compatible only. This works fine
> and there is no bug here, however guidelines expressed in
> Documentation/devicetree/bindings/writing-bindings.rst state that:
> 1. Compatibles should be specific.
> 2. We should add new compatibles in case of bugs or features.
>
> Add compatibles specific to each SoC in front of all old-SoC-like
> compatibles.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
>
> I propose to take the patch through Samsung SoC (me). See cover letter
> for explanation.
I am fine that you take it once all review comments are addressed. Given
that:
Acked-by: Wolfram Sang <wsa@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
[Index of Archives]
[Linux SPI]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|