On Thu, Nov 02, 2023 at 08:06:41AM +0000, Cristian Marussi wrote: > On Fri, Oct 27, 2023 at 06:28:10AM +0000, Oleksii Moisieiev wrote: > > Add basic implementation of the SCMI v3.2 pincontrol protocol. > > > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx> > > --- > > Hi Oleksii, > > the new get/set v3.2 implementation seems finer to me at first sight. > I'll try to test this next days and give you more feedback. I don't think that this version addresses my comment yet: https://lkml.iu.edu//hypermail/linux/kernel/2308.2/07483.html I hope that it will be fixed in your *final* v5. -Takahiro Akashi > Thanks, > Cristian