On Fri, Oct 27, 2023 at 03:14:23PM +0800, Linhua Xu wrote: > From: Linhua Xu <Linhua.Xu@xxxxxxxxxx> > > For UNISOC pin controller, the offset values of the common > register and misc register will be different. So add SoC > structure in sprd_pinctrl_of_match() and parse it in sprd-pinctrl_core. ... > + priv_data = of_device_get_match_data(&pdev->dev); > + if (!priv_data) > + return -EINVAL; I believe there is the idea to make that API local to the device property core, so use device_get_match_data() instead. -- With Best Regards, Andy Shevchenko