Re: [PATCH v3 54/73] pinctrl: intel: drop the wrappers around pinctrl_gpio_direction_input()

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Tue, Oct 17, 2023 at 02:04:12PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> pinctrl_gpio_direction_input() now has the same signature as the
> wrappers around it so we can drop them.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Now, for the sake of symmetry can you add (at least to the all
Intel drivers you modified in this series) the following:


int pinctrl_gpio_direction_output_with_value(struct gpio_chip *gc,
					     unsigned int offset, int value)
{
	gc->set(gc, offset, value);
        return pinctrl_gpio_direction_output(gc, offset);
}


?

And respectively in this driver

	.direction_output = pincttl_gpio_direction_output_with_value,


-- 
With Best Regards,
Andy Shevchenko