Re: [PATCH 1/1] gpio: tegra186: Set fwnode of the GPIO chip

[Andy Shevchenko <andy@xxxxxxxxxx>]

On Tue, Oct 10, 2023 at 04:13:19PM +0300, Andy Shevchenko wrote:
> On Mon, Oct 09, 2023 at 10:38:58AM -0700, Dipen Patel wrote:

...

> > +	/*
> > +	 * This is needed for driver using gpio device matching where it
> > +	 * has to use gpio_chip fwnode to match the gpio controller.
> > +	 */
> > +	gpio->gpio.fwnode = of_node_to_fwnode(pdev->dev.of_node);
> 
> of_node_to_fwnode() is specific to IRQ, in other places we use generic
> of_fwnode_handle(). That's why better just to use dev_fwnode().

On the second thought is there any parent assigned?
At least I see that in tegra186_gpio_probe(). Are you saying
it is not working? Or is it (matching) called _before_ we
add a GPIO device?

-- 
With Best Regards,
Andy Shevchenko