On Thu, 28 Sep 2023 09:06:44 +0200 Herve Codina wrote: > + for (i = 0; i < count; i++) { > + (audio_devs + i)->name = "framer-codec"; > + (audio_devs + i)->of_compatible = compatible; > + (audio_devs + i)->id = i; Why not array notation? > + } > + > + ret = mfd_add_devices(pef2256->dev, 0, audio_devs, count, NULL, 0, NULL); Should Lee be CCed for the MFD part?