Re: [PATCH] pinctrl: realtek: Fix error handling in probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 5, 2023 at 4:01 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> There are several issues in the probe function:
> 1) of_iomap() return NULL on error but the code checks for error
>    pointers.
> 2) pinctrl_register() is the reverse.  It returns error pointers
>    but the code checks for NULL.
> 3) The error paths need to call iounmap(data->base) before returning
>    to avoid a resource leak.
>
> Fixes: e99ce78030db ("pinctrl: realtek: Add common pinctrl driver for Realtek DHC RTD SoCs")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Patch applied, excellent work as always.

I just sent out some more patches to the Realtek stuff, I could revert
it but it's overall nice to have so I try to just fix it up.

Yours,
Linus Walleij




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux