Re: [PATCH 07/21] dt-bindings: pinctrl: samsung: add google,gs101-pinctrl compatible

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 05/10/2023 17:56, Peter Griffin wrote:
> Add the "google,gs101-pinctrl" compatible to the dt-schema bindings
> documentation.
> 
> Add maxItems of 50 for the interrupts property as gs101 can have
> multiple irqs.
> 
> Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/pinctrl/samsung,pinctrl.yaml          | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> index 26614621774a..e0f37f8ae8e7 100644
> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> @@ -54,11 +54,13 @@ properties:
>        - samsung,exynos850-pinctrl
>        - samsung,exynosautov9-pinctrl
>        - tesla,fsd-pinctrl
> +      - google,gs101-pinctrl

Alphanumerical order

>  
>    interrupts:
>      description:
>        Required for GPIO banks supporting external GPIO interrupts.
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 50

You need to add to allOf: a new "if:then:else:" which will:
1. narrow this for Google (with some description - is it interrupt per
GPIO? per bank?)
2. else: maxItems: 1




Best regards,
Krzysztof