On 03-10-23, 11:17, Erik Schilling wrote: > Ah, I posted some weak opposition against that in [1], but failed to > mention that again for v2. I mostly disliked `Info::from_raw()` being > not very expressive without peeking at the type definition. But if you > feel strongly about this, I am happy to change it. I feel `Info` and `InfoRef` speak enough for themselves and what they contain and I don't see a need for the routines to be named specially anymore. > I would strongly vote for `from_raw()` since `new()` sounds like it > would create a new instance, but really, we are just wrapping an already > existing instance here. > > So... Shall I move to `from_raw()` or keep > `from_raw_owned/non_owning()`? I like the simplified version, i.e. `from_raw()` for sure. Unless someone else have an objection to that. -- viresh