Re: [PATCH 2/2] gpio: ixp4xx: Handle clock output on pin 14 and 15

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Sep 21, 2023 at 1:23 PM Andy Shevchenko <andy@xxxxxxxxxx> wrote:

> Maybe
>
>         if (...)
>                 val = 0;
>         else
>                 val = readl();
>
> ?

Neat, I'll do this!

> > +     /*
> > +      * Enable clock outputs with default timings of requested clock.
> > +      * If you need control over TC and DC, add these to the device
> > +      * tree bindings and use them here.
> > +      */
>
> Shouldn't this be integrated into PPS subsystem?

PPS is for GPS, we *could* integrate it into the clk subsystem (with
configuration cells and all hoopla) but as I state in the cover letter
I think it becomes overengineered for this legacy system, there are
no users or benefit of that added complexity as compared to these
few-liners.

Yours,
Linus Walleij