On Fri, Sep 08, 2023 at 01:51:41PM +0800, Linhua Xu wrote: > From: Linhua Xu <Linhua.Xu@xxxxxxxxxx> > > For UNISOC pin controller, the offset values of the common register and > misc register will be different. Thus put these in the probe function > parameters. ... > +#define PINCTRL_REG_OFFSET 0x20 0x0020 to make it look as related to the other one, as they are of the same type: register offsets. > +#define PINCTRL_REG_MISC_OFFSET 0x4020 -- With Best Regards, Andy Shevchenko