On Fri, Sep 08, 2023 at 01:51:43PM +0800, Linhua Xu wrote: > From: Linhua Xu <Linhua.Xu@xxxxxxxxxx> > > For UNISOC pin controller, there are three different configurations of > pull-up drive current. Modify the 20K pull-up resistor configuration and > add the 1.8K pull-up resistor configuration. ... > -#define PULL_UP_4_7K (BIT(12) | BIT(7)) > +#define PULL_UP_1_8K (BIT(12) | BIT(7)) > +#define PULL_UP_4_7K BIT(12) This looks like a real fix, please add Fixes tag and move the patch to be the first in the series. -- With Best Regards, Andy Shevchenko
Re: [PATCH V2 3/6] pinctrl: sprd: Modify pull-up parameters
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH V2 3/6] pinctrl: sprd: Modify pull-up parameters
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Mon, 11 Sep 2023 12:51:52 +0300
- In-reply-to: <20230908055146.18347-4-Linhua.xu@unisoc.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20230908055146.18347-1-Linhua.xu@unisoc.com> <20230908055146.18347-4-Linhua.xu@unisoc.com>
- References:
- [PATCH V2 0/6] pinctrl: sprd: Modification of UNIOC Platform pinctrl Driver
- From: Linhua Xu
- [PATCH V2 3/6] pinctrl: sprd: Modify pull-up parameters
- From: Linhua Xu
- [PATCH V2 0/6] pinctrl: sprd: Modification of UNIOC Platform pinctrl Driver
- Prev by Date: Re: [PATCH v5 11/17] qcom_minidump: Register ramoops region with minidump
- Next by Date: linusw/for-next baseline: 47 runs, 1 regressions (v6.6-rc1)
- Previous by thread: [PATCH V2 3/6] pinctrl: sprd: Modify pull-up parameters
- Next by thread: Re: [PATCH V2 3/6] pinctrl: sprd: Modify pull-up parameters
- Index(es):
 |