On Sat, Sep 09, 2023 at 01:18:59PM +0100, Biju Das wrote: > This patch series aims to add match data improvements for mcp23s08 driver. > This patch series is only compile tested. Now, do you see the common grounds for unifying two data structure types you created? IN the common header you may introduce a type and use it in the both files. For the patches 1 & 3 (the API simplification): Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> -- With Best Regards, Andy Shevchenko