Re: [PATCH V2 6/6] pinctrl: sprd: Add pinctrl support for UMS9621

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Fri, Sep 08, 2023 at 01:51:46PM +0800, Linhua Xu wrote:
> From: Linhua Xu <Linhua.Xu@xxxxxxxxxx>
> 
> Add the pin control driver for UNISOC UMS9621 platform.

> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/platform_device.h>
> +

...

> +#define	PINCTRL_REG_OFFSET		0x44

0x0044

> +#define	PINCTRL_REG_MISC_OFFSET		0x444

...

> +static const struct of_device_id sprd_pinctrl_of_match[] = {
> +	{ .compatible = "sprd,ums9621-pinctrl", },

Inner comma is not needed.

> +	{ }
> +};


-- 
With Best Regards,
Andy Shevchenko