On Fri, Sep 1, 2023 at 1:35 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > 'extern' doesn't do anything for function declarations. Remove it. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> Right I guess it should never be in headers, the one place where is makes sense is if you're suddenly exporting something in a C file, such as to expose it to assembly. Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij