Re: [PATCH 2/2] gpiolib: rename gpio_chip_hwgpio() for consistency

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Mon, Sep 4, 2023 at 11:27 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Mon, Sep 04, 2023 at 09:34:10AM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > All other functions that manipulate a struct gpio_desc use the gpiod_
> > prefix. Follow this convention and rename gpio_chip_hwgpio() to
> > gpiod_get_hwgpio().
>
> Same comment. Also, I don't think it's good idea as it steps on the exported
> API's toes. I.o.w. I won't mix those two.
>

Even if I agreed with your other comment, gpio_chip_hwgpio() is a
terrible name and if I didn't know, I couldn't tell you what it does
just from looking at the name.

Bart