Re: [PATCH v2] gpio: sim: don't fiddle with GPIOLIB private members

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Sun, Sep 03, 2023 at 09:17:48PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> We access internals of struct gpio_device and struct gpio_desc because
> it's easier but it can actually be avoided and we're working towards a
> better encapsulation of GPIO data structures across the kernel so let's
> start at home.
> 
> Instead of checking gpio_desc flags, let's just track the requests of
> GPIOs in the driver. We also already store the information about
> direction of simulated lines.
> 
> For kobjects needed by sysfs callbacks: we can leverage the fact that
> once created for a software node, struct device is accessible from that
> fwnode_handle. We don't need to dereference gpio_device.
> 
> While at it: fix one line break and remove the untrue part about
> configfs callbacks using dev_get_drvdata() from a comment.

> ---
> v1 -> v2:
> - use get_dev_from_fwnode() instead of dereferencing fwnode directly

Still no.

-- 
With Best Regards,
Andy Shevchenko