On Sat, Sep 02, 2023 at 10:09:37AM +0100, Biju Das wrote: > Add struct mcp23s08_i2c_info and simplify probe() by replacing > match data 'type' with 'struct mcp23s08_i2c_info'. > > While at it, replace dev_err()->dev_err_probe(). '->' --> ' --> ' ... > + info = i2c_get_match_data(client); > + if (!info) > + return dev_err_probe(dev, -EINVAL, "invalid device type (%d)\n", > + info->type); Huh?! Please, think about it... -- With Best Regards, Andy Shevchenko
Re: [PATCH 2/2] pinctrl: mcp23s08: Simplify probe()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 2/2] pinctrl: mcp23s08: Simplify probe()
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Mon, 4 Sep 2023 12:12:07 +0300
- In-reply-to: <20230902090937.32195-3-biju.das.jz@bp.renesas.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20230902090937.32195-1-biju.das.jz@bp.renesas.com> <20230902090937.32195-3-biju.das.jz@bp.renesas.com>
- References:
- [PATCH 0/2] Match data improvements for mcp23s08 driver
- From: Biju Das
- [PATCH 2/2] pinctrl: mcp23s08: Simplify probe()
- From: Biju Das
- [PATCH 0/2] Match data improvements for mcp23s08 driver
- Prev by Date: Re: [PATCH 1/2] pinctrl: mcp23s08: Extend match support for OF tables
- Next by Date: Re: [PATCH 0/2] Match data improvements for mcp23s08 driver
- Previous by thread: [PATCH 2/2] pinctrl: mcp23s08: Simplify probe()
- Next by thread: Re: [PATCH 2/2] pinctrl: mcp23s08: Simplify probe()
- Index(es):
 |