On Fri, Aug 25, 2023 at 11:18:22AM +0800, Linhua Xu wrote: > From: Linhua Xu <Linhua.Xu@xxxxxxxxxx> > > Pull-up and pull-down are mutually exclusive. When setting one of them, > the bit of the other needs to be clear. Now, there are cases where pull-up > and pull-down are set at the same time in the code, thus fix them. ... > -#define SLEEP_PULL_DOWN_MASK 0x1 > +#define SLEEP_PULL_DOWN_MASK 0x3 GENMASK() ... > -#define PULL_DOWN_MASK 0x1 > +#define PULL_DOWN_MASK 0x3 GENMASK() ... > -#define SLEEP_PULL_UP_MASK 0x1 > +#define SLEEP_PULL_UP_MASK 0x3 GENMASK() ... > -#define PULL_UP_MASK 0x21 > +#define PULL_UP_MASK 0x43 GENMASK() + BIT()? -- With Best Regards, Andy Shevchenko
Re: [PATCH 2/6] pinctrl: sprd: Fix the incorrect mask and shift definition
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 2/6] pinctrl: sprd: Fix the incorrect mask and shift definition
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Fri, 25 Aug 2023 13:10:56 +0300
- In-reply-to: <20230825031826.31599-3-Linhua.xu@unisoc.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20230825031826.31599-1-Linhua.xu@unisoc.com> <20230825031826.31599-3-Linhua.xu@unisoc.com>
- References:
- Prev by Date: Re: [PATCH 1/6] pinctrl: sprd: Modify the probe function parameters
- Next by Date: Re: [PATCH 3/6] pinctrl: sprd: Modify pull-up parameters
- Previous by thread: [PATCH 2/6] pinctrl: sprd: Fix the incorrect mask and shift definition
- Next by thread: [PATCH 4/6] pinctrl: sprd: Add pinctrl support for UMS512
- Index(es):
 |