RE: [PATCH] gpio: pca953x: Use i2c_get_match_data()

[Biju Das <biju.das.jz@xxxxxxxxxxxxxx>]

Hi Andy Shevchenko,

Thanks for the feedback.

> Subject: Re: [PATCH] gpio: pca953x: Use i2c_get_match_data()
> 
> On Sat, Aug 19, 2023 at 06:37:47PM +0100, Biju Das wrote:
> > Replace device_get_match_data() and id lookup for retrieving match
> > data by i2c_get_match_data().
> 
> ...
> 
> > -	if (i2c_id) {
> > -		chip->driver_data = i2c_id->driver_data;
> > -	} else {
> > -		const void *match;
> > -
> > -		match = device_get_match_data(&client->dev);
> > -		if (!match) {
> > -			ret = -ENODEV;
> > -			goto err_exit;
> > -		}
> > -
> > -		chip->driver_data = (uintptr_t)match;
> > +	chip->driver_data = (uintptr_t)i2c_get_match_data(client);
> > +	if (!chip->driver_data) {
> > +		ret = -ENODEV;
> > +		goto err_exit;
> >  	}
> 
> Can you move this to be called before devm_regulator_get()? It doesn't
> require regulator to be enabled for functioning.

OK will do.

Cheers,
Biju