On Mon, Aug 21, 2023 at 5:04 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > On Mon, Aug 21, 2023 at 2:55 PM Asmaa Mnebhi <asmaa@xxxxxxxxxx> wrote: > > > > > > +MODULE_SOFTDEP("pre: pinctrl-mlxbf3"); > > > > MODULE_DESCRIPTION("NVIDIA BlueField-3 GPIO Driver"); > > > > MODULE_AUTHOR("Asmaa Mnebhi <asmaa@xxxxxxxxxx>"); > > > > MODULE_LICENSE("Dual BSD/GPL"); > > > > -- > > > > 2.30.1 > > > > > > > > > > It's not clear to me whether this depends on patch 1? If only at run-time then I > > > guess Linus and I can take the two patches through ours respective trees? > > > > Indeed from a build point of view, there is no dependency so you could take the 2 patches through your respective tree. However, at run-time, the gpio-mlxbf3.c driver fails to load without the pinctrl-mlxbf3.c driver. Should I add a "depends on" in the Kconfig? Then you will have to include both patches in your tree. > > > > Linus, are you fine with me taking this patch? It will not break the > build and with you taking the other one, next will be fine too. Yep pick this one, I applied 1/2 to the pinctrl tree now. Yours, Linus Walleij