Re: [PATCH 2/2] gpio: mxc: switch to dynamic allocat GPIO base

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Aug 21, 2023 at 9:44 AM Alexander Stein
<alexander.stein@xxxxxxxxxxxxxxx> wrote:
> Am Montag, 21. August 2023, 09:25:54 CEST schrieb Linus Walleij:
> > On Mon, Aug 21, 2023 at 4:47 AM Bough Chen <haibo.chen@xxxxxxx> wrote:> > Hi
> Linus and Bartosz,
> > >
> > > For this patch, still not in the main trunk (Linux 6.5-rc7) and
> > > linux-next(next-20230818). Can you help apply or any comment?
> >
> > As pointed out by Bartosz you cannot just mechanically switch the base
> > to -1.
> >
> > You also need to convince us that this doesn't break any systems, and if
> > it does, fix them so they don't break before submitting this patch.
>
> I think it's hard to tell if something breaks, this driver is used in a lot of
> boards. AFAIR some people are relying on the assumption of fixed order. Using
> dynamic allocation this not ensured. A possible fix is to use aliases [1].

Hm I might have been to grumpy!

It looks like any boardfiles using gpio-mxc have been eliminated
so this driver is now only used in device tree-boots? Right?

Then I feel a lot better about it.

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij