Re: [PATCH v4 21/28] net: wan: Add framer framework support

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Aug 21, 2023 at 7:19 AM Christophe Leroy
<christophe.leroy@xxxxxxxxxx> wrote:
> Le 20/08/2023 à 23:06, Linus Walleij a écrit :
> > On Fri, Aug 18, 2023 at 6:41 PM Christophe Leroy
> > <christophe.leroy@xxxxxxxxxx> wrote:
> >
> >> From: Herve Codina <herve.codina@xxxxxxxxxxx>
> >>
> >> A framer is a component in charge of an E1/T1 line interface.
> >> Connected usually to a TDM bus, it converts TDM frames to/from E1/T1
> >> frames. It also provides information related to the E1/T1 line.
> >>
> >> The framer framework provides a set of APIs for the framer drivers
> >> (framer provider) to create/destroy a framer and APIs for the framer
> >> users (framer consumer) to obtain a reference to the framer, and
> >> use the framer.
> >>
> >> This basic implementation provides a framer abstraction for:
> >>   - power on/off the framer
> >>   - get the framer status (line state)
> >>   - be notified on framer status changes
> >>   - get/set the framer configuration
> >>
> >> Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>
> >> Reviewed-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
> >> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
> >
> > I had these review comments, you must have missed them?
> > https://lore.kernel.org/netdev/CACRpkdZQ9_f6+9CseV1L_wGphHujFPAYXMjJfjUrzSZRakOBzg@xxxxxxxxxxxxxx/
> >
>
> As I said in the cover letter, this series only fixes critical build
> failures that happened when CONFIG_MODULES is set. The purpose was to
> allow robots to perform their job up to the end. Other feedback and
> comments will be taken into account by Hervé when he is back from holidays.

Ah I see. I completely missed this.

Yours,
Linus Walleij