On Fri, Aug 18, 2023 at 05:30:15PM +0800, Li Zetao wrote:
> Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for
> prepared and enabled clocks"), devm_clk_get() and clk_prepare() can now be
> replaced by devm_clk_get_prepared() when the driver enables (and possibly
> prepares) the clocks for the whole lifetime of the device. Moreover, it is
> no longer necessary to unprepare and disable the clocks explicitly.
The commit message isn't correct. Seems you copied'n'pasted from other cases.
Please, revisit.
Code wise looks legit to me.
With the commit message fixed
Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko
Re: [PATCH -next 08/11] gpio: omap: Use helper function devm_clk_get_prepared()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH -next 08/11] gpio: omap: Use helper function devm_clk_get_prepared()
- From: Andy Shevchenko <andy@xxxxxxxxxx>
- Date: Fri, 18 Aug 2023 18:00:22 +0300
- In-reply-to: <20230818093018.1051434-9-lizetao1@huawei.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20230818093018.1051434-1-lizetao1@huawei.com> <20230818093018.1051434-9-lizetao1@huawei.com>
- References:
- Prev by Date: [PATCH] pinctrl: amd: Mask wake bits on probe again
- Next by Date: Re: [PATCH -next 09/11] gpio: stp-xway: Use helper function devm_clk_get_enabled()
- Previous by thread: [PATCH -next 08/11] gpio: omap: Use helper function devm_clk_get_prepared()
- Next by thread: [PATCH -next 09/11] gpio: stp-xway: Use helper function devm_clk_get_enabled()
- Index(es):
 |