On Fri, Aug 18, 2023 at 05:30:11PM +0800, Li Zetao wrote: > Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for > prepared and enabled clocks"), devm_clk_get() and clk_prepare_enable() > can now be replaced by devm_clk_get_enabled() when the driver enables > (and possibly prepares) the clocks for the whole lifetime of the device. > Moreover, it is no longer necessary to unprepare and disable the clocks > explicitly. ... > - dev_err(dev, "input clock not found\n"); > + dev_err(dev, > + "input clock not found or unable to enable clock\n"); Do not alter the message right now. With the dev_err_probe() conversion it can be done, if you wish. So it will be less churn. -- With Best Regards, Andy Shevchenko