On Fri, Aug 18, 2023 at 05:30:13PM +0800, Li Zetao wrote: > Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for > prepared and enabled clocks"), devm_clk_get() and clk_prepare_enable() > can now be replaced by devm_clk_get_enabled() when the driver enables > (and possibly prepares) the clocks for the whole lifetime of the device. > Moreover, it is no longer necessary to unprepare and disable the clocks > explicitly. ... > - mvchip->clk = devm_clk_get(&pdev->dev, NULL); > /* Not all SoCs require a clock.*/ > - if (!IS_ERR(mvchip->clk)) > - clk_prepare_enable(mvchip->clk); > + mvchip->clk = devm_clk_get_enabled(&pdev->dev, NULL); The clk is only used in the PWM part, move it there and remove clk member from the private struct. -- With Best Regards, Andy Shevchenko