> Better now, > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > ... > > > #define MLXBF3_GPIO_MAX_PINS_PER_BLOCK 32 > > +#define MLXBF3_GPIO_MAX_PINS_BLOCK0 > MLXBF3_GPIO_MAX_PINS_PER_BLOCK > > +#define MLXBF3_GPIO_MAX_PINS_BLOCK1 24 > > Since it's a fix for backporting, I'm not insisting to amend it now, but can we > actually drop the common define and use > > #define MLXBF3_GPIO_MAX_PINS_BLOCK0 32 > #define MLXBF3_GPIO_MAX_PINS_BLOCK1 24 > > and modify code accordingly, please? Sure. Will send a v4 addressing this.