Re: [PATCH -next v2] I2C: Fix return value check for devm_pinctrl_get()

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Aug 18, 2023 at 7:33 AM Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:

> NULL is returned on purpose. When PINCTRL is disabled NULL becomes a
> valid pinctrl cookie which can be passed to the other stub functions.
> With this drivers using pinctrl can get through their probe function
> without an error when PINCTRL is disabled.
>
> The same approach is taken by the clk and regulator API.
>
> It is correct to test the return value of devm_pinctrl_get() with
> IS_ERR(), only the commit message of these patches is a bit inaccurate.

Sascha is spot on, maybe copyedit some of the above
into the commit message and resend?

Yours,
Linus Walleij