Re: [PATCH 1/3] pinctrl: renesas: rzg2l: Fix NULL pointer dereference in rzg2l_dt_subnode_to_map()

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Aug 15, 2023 at 11:32 AM Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> On Tue, Aug 15, 2023 at 11:14 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> > On Mon, Aug 14, 2023 at 9:24 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > > Fix the below random NULL pointer crash during boot by serializing
> > > pinctrl group and function creation/remove calls in
> > > rzg2l_dt_subnode_to_map() with mutex lock.
> >
> > What about using, hehe, scoped guards? Bartosz premiered the use
> > of this and I already like it a lot... see:
> > https://lore.kernel.org/linux-gpio/20230812183635.5478-1-brgl@xxxxxxxx/
>
> Quoting the other Linus:
>
>    "We should probably also strive to avoid it for bug-fixes that end up
>     going to stable."
>
> https://lore.kernel.org/all/CAHk-=wjsb5gZTvhXofPCQthk48S9_bSGohXKU8x8XDnf7=bROw@xxxxxxxxxxxxxx

Right, I missed it's an urgent fix :/

Let's put a mental note to sweep over the driver once this is done and
see if we can use scoped guards to avoid more problems in the future?

Yours,
Linus Walleij