Re: [PATCH -next] gpiolib: acpi: Use LIST_HEAD() to initialize the list_head

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Sun, Aug 13, 2023 at 08:49:28PM +0200, Bartosz Golaszewski wrote:
> On Sat, Aug 12, 2023 at 9:14 AM Ruan Jinjie <ruanjinjie@xxxxxxxxxx> wrote:
> >
> > Use LIST_HEAD() to initialize the list_head instead of open-coding it.

...

> My opinion: this is actually less readable than what is there now and
> I doubt the compiler would generate less code. With this change I now
> need to check what LIST_HEAD() actually does, while defining a temp
> variable of a clear type and then using a macro to initialize it is
> much more obvious.
> 
> I'll let Andy decide as ACPI is his domain but for me it's a NAK.

The code is identical, I have no strong opinion (I'm fine with the either),
since you already have an opinion, let it be NAK then.

-- 
With Best Regards,
Andy Shevchenko