Re: [PATCH v3 05/28] soc: fsl: cpm1: qmc: Remove inline function specifiers

[Christophe Leroy <christophe.leroy@xxxxxxxxxx>]

Le 09/08/2023 à 15:27, Herve Codina a écrit :
> The inline function specifier is present on some functions but it is
> better to let the compiler decide inlining or not these functions.

And anyway the compiler can decide to not inline a function marked 
inline since commit ac7c3e4ff401 ("compiler: enable 
CONFIG_OPTIMIZE_INLINING forcibly") followed by commit 889b3c1245de 
("compiler: remove CONFIG_OPTIMIZE_INLINING entirely").

So unless you mark it __always_inline you have no guarranty that the 
compiler does what you tell it to do.

> 
> Remove inline specifiers.
> 
> Fixes: 3178d58e0b97 ("soc: fsl: cpm1: Add support for QMC")
> Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>
> Suggested-by: Andrew Lunn <andrew@xxxxxxx>

Reviewed-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>

> ---
>   drivers/soc/fsl/qe/qmc.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index 2d2a9d88ba6c..459e0bbd723d 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -218,37 +218,37 @@ struct qmc {
>   	struct qmc_chan *chans[64];
>   };
>   
> -static inline void qmc_write16(void __iomem *addr, u16 val)
> +static void qmc_write16(void __iomem *addr, u16 val)
>   {
>   	iowrite16be(val, addr);
>   }
>   
> -static inline u16 qmc_read16(void __iomem *addr)
> +static u16 qmc_read16(void __iomem *addr)
>   {
>   	return ioread16be(addr);
>   }
>   
> -static inline void qmc_setbits16(void __iomem *addr, u16 set)
> +static void qmc_setbits16(void __iomem *addr, u16 set)
>   {
>   	qmc_write16(addr, qmc_read16(addr) | set);
>   }
>   
> -static inline void qmc_clrbits16(void __iomem *addr, u16 clr)
> +static void qmc_clrbits16(void __iomem *addr, u16 clr)
>   {
>   	qmc_write16(addr, qmc_read16(addr) & ~clr);
>   }
>   
> -static inline void qmc_write32(void __iomem *addr, u32 val)
> +static void qmc_write32(void __iomem *addr, u32 val)
>   {
>   	iowrite32be(val, addr);
>   }
>   
> -static inline u32 qmc_read32(void __iomem *addr)
> +static u32 qmc_read32(void __iomem *addr)
>   {
>   	return ioread32be(addr);
>   }
>   
> -static inline void qmc_setbits32(void __iomem *addr, u32 set)
> +static void qmc_setbits32(void __iomem *addr, u32 set)
>   {
>   	qmc_write32(addr, qmc_read32(addr) | set);
>   }