RE: [EXT] Re: [PATCH] gpio: mxc: release the parent IRQ in runtime suspend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Sent: Tuesday, August 8, 2023 4:42 PM
> To: Shenwei Wang <shenwei.wang@xxxxxxx>
> Cc: Andy Shevchenko <andy@xxxxxxxxxx>; Linus Walleij
> > > > +static void mxc_update_irq_chained_handler(struct mxc_gpio_port
> > > > +*port, bool enable) {
> > > > +     if (!port)
> > > > +             return;
> > >
> > > When can this be true?
> >
> > If the function is called at right place and right time, it won't be
> > true. Just in case. 😊
> 
> I'm not sure I get this. If you try to add a dead code, don't do that.
> Otherwise can you clarify at which circumstances it can be not a dead code?
> 

Okay. Will remove it in next version.

Thanks,
Shenwei

> --
> With Best Regards,
> Andy Shevchenko




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux