> -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Sent: Tuesday, August 8, 2023 4:42 PM > To: Shenwei Wang <shenwei.wang@xxxxxxx> > Cc: Andy Shevchenko <andy@xxxxxxxxxx>; Linus Walleij > > > > +static void mxc_update_irq_chained_handler(struct mxc_gpio_port > > > > +*port, bool enable) { > > > > + if (!port) > > > > + return; > > > > > > When can this be true? > > > > If the function is called at right place and right time, it won't be > > true. Just in case. 😊 > > I'm not sure I get this. If you try to add a dead code, don't do that. > Otherwise can you clarify at which circumstances it can be not a dead code? > Okay. Will remove it in next version. Thanks, Shenwei > -- > With Best Regards, > Andy Shevchenko