Hi TY Chang, thanks for the patches! On Wed, Jul 26, 2023 at 11:06 AM TY Chang <tychang@xxxxxxxxxxx> wrote: > These patches add the bindings and the pinctrl drivers for Realtek > DHC(Digital Home Center) RTD SoCs(RTD1619B, RTD1319D and RTD1315E). I really like the architecture with a central driver an modules for each SoC that makes this nicely maintainable in the future. There are some questions around the NMOS/PMOS totempole config (I guess that is what it is) so we need to hash that out into the documentation, then I think the rest falls into place pretty naturally. Yours, Linus Walleij