Re: [PATCH -next v2] gpio: altera-a10sr: remove redundant of_match_ptr

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Wed, Aug 2, 2023 at 4:24 AM Zhu Wang <wangzhu9@xxxxxxxxxx> wrote:
>
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr() here.
>
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it. Hence we remove of_match_ptr().
>
> Signed-off-by: Zhu Wang <wangzhu9@xxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> ---
> Changes in v2:
> - Change of_match_ptr to of_match_ptr()
> - Include mod_devicetable.h
> ---
>  drivers/gpio/gpio-altera-a10sr.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-altera-a10sr.c b/drivers/gpio/gpio-altera-a10sr.c
> index be1ed7ee5225..11edf1fe6c90 100644
> --- a/drivers/gpio/gpio-altera-a10sr.c
> +++ b/drivers/gpio/gpio-altera-a10sr.c
> @@ -9,6 +9,7 @@
>
>  #include <linux/gpio/driver.h>
>  #include <linux/mfd/altera-a10sr.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/property.h>
>
> @@ -104,7 +105,7 @@ static struct platform_driver altr_a10sr_gpio_driver = {
>         .probe = altr_a10sr_gpio_probe,
>         .driver = {
>                 .name   = "altr_a10sr_gpio",
> -               .of_match_table = of_match_ptr(altr_a10sr_gpio_of_match),
> +               .of_match_table = altr_a10sr_gpio_of_match,
>         },
>  };
>  module_platform_driver(altr_a10sr_gpio_driver);
> --
> 2.17.1
>

Applied, thanks!

Bart