Re: [PATCH] gpio: sifive: remove unneeded call to platform_set_drvdata()

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Tue, Aug 1, 2023 at 9:44 AM Andrei Coardos <aboutphysycs@xxxxxxxxx> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@xxxxxxxxxxx>
> Signed-off-by: Andrei Coardos <aboutphysycs@xxxxxxxxx>
> ---
>  drivers/gpio/gpio-sifive.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-sifive.c b/drivers/gpio/gpio-sifive.c
> index c6a8d2374e31..0010f607a9ef 100644
> --- a/drivers/gpio/gpio-sifive.c
> +++ b/drivers/gpio/gpio-sifive.c
> @@ -259,7 +259,6 @@ static int sifive_gpio_probe(struct platform_device *pdev)
>         girq->child_to_parent_hwirq = sifive_gpio_child_to_parent_hwirq;
>         girq->handler = handle_bad_irq;
>         girq->default_type = IRQ_TYPE_NONE;
> -       platform_set_drvdata(pdev, priv);
>
>         return gpiochip_add_data(&chip->gc, chip);
>  }
> --
> 2.34.1
>

This patch does not correspond with the code upstream. Please verify.

Bart