Re: [PATCH v2] gpio: mlxbf2: remove unneeded platform_set_drvdata() call

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Tue, Jul 25, 2023 at 3:13 PM Andy Shevchenko <andy@xxxxxxxxxx> wrote:
>
> On Tue, Jul 25, 2023 at 03:30:45PM +0300, Andrei Coardos wrote:
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver.
>
> This is simply not true.
>
> NAK.
>

Just so you know if that's not obvious from reading the code:
platform_get_drvdata() is just a wrapper around dev_get_drvdata()
which is called plenty in PM callbacks of this driver.

Bart

> > Also, the private data is defined in this driver, so there is no risk of
> > it being accessed outside of this driver file.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>