On Tue, Aug 01, 2023 at 11:36:58AM +0800, Zhu Wang wrote: > The driver depends on CONFIG_OF, so it is not necessary to use > of_match_ptr here, and __maybe_unused can also be removed. of_match_ptr() > Even for drivers that do not depend on CONFIG_OF, it's almost always > better to leave out the of_match_ptr(), since the only thing it can > possibly do is to save a few bytes of .text if a driver can be used both > with and without it. Also drop no more needed of_device.h. OTOH spi/spi.h de facto guarantees mod_devicetable.h to be included. -- With Best Regards, Andy Shevchenko