Re: [PATCH -next] gpio: altera-a10sr: remove redundant of_match_ptr

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Tue, Aug 01, 2023 at 11:34:28AM +0800, Zhu Wang wrote:
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr here.

of_match_ptr()

> 
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it. Hence we remove of_match_ptr.

of_match_ptr()


Driver even doesn't include required of.h for this...
But with your change you have to provide mod_devicetable.h.

Good change,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
after updating the commit message and adding missing header.

-- 
With Best Regards,
Andy Shevchenko