There is no need to call the dev_err_probe() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Signed-off-by: Ruan Jinjie <ruanjinjie@xxxxxxxxxx> Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx> --- v2: - split into 2 patches on per-driver basis --- drivers/gpio/gpio-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index 2b78fde74e30..21c8cfedfd64 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1415,7 +1415,7 @@ static int omap_gpio_probe(struct platform_device *pdev) if (bank->irq <= 0) { if (!bank->irq) bank->irq = -ENXIO; - return dev_err_probe(dev, bank->irq, "can't get irq resource\n"); + return bank->irq; } bank->chip.parent = dev; -- 2.34.1