The 07/20/2023 14:02, Colin Foster wrote: Hi, > > On Thu, Jul 20, 2023 at 09:25:32PM +0200, Linus Walleij wrote: > > On Wed, Jul 12, 2023 at 4:23 AM Colin Foster > > <colin.foster@xxxxxxxxxxxxxxxx> wrote: > > > > > Add additional functions - two blink and two activity, for each SGPIO > > > output. > > > > > > Signed-off-by: Colin Foster <colin.foster@xxxxxxxxxxxxxxxx> > > > > Could Lars or Horatiu review this patch? You guys know the driver > > best. > > Agreed. Please don't merge this without their approval and hopefully > testing. > I have tried to apply the patch to test it, but unfortunately it doesn't apply. I have looked through the changes and they seem OK. > I did demote this patch I've been dragging around since 2021 to RFC > status because I'm more interested in making sure it will fit in with > the work on hardware-offloaded network activity LED work that's being > done. I took Andrew's response to the cover letter as an suggestion to > hold off for a little while longer. I can be patient. > > Also, this RFC was two-fold. I don't want to duplicate efforts, and I > know this pinctrl driver was written with this functionality in mind. If > someone out there has a hankering to get those LEDs blinking and they > don't want to wait around for me, feel free to use this as a starting > point. I might not get around to the whole netdev trigger thing for > quite some time! > > > Colin Foster -- /Horatiu