On Thu, Jul 20, 2023 at 4:26 PM Andrei Coardos <aboutphysycs@xxxxxxxxx> wrote: > > This function call is not required because no counterpart > platform_get_drvdata() call is present to leverage the private data of > the driver. > Since the private data is confined to this driver file, external access > is not feasible. > The use of this function appears redundant in the current context of the > driver's implementation. Use full room of the lines, no need to start each sentence at a new line. Also, fix the Subject. It should be prefixed with "gpio: DRIVER: ", where DRIVER is one in question. This applies to all your last patches. -- With Best Regards, Andy Shevchenko